Code reviewMediumcr-g359

Subject Inconsistent errorsLevel Mid–Senior~20 minCommon in Databases & SQL interviewsIndustries Software development, Technology

Question

Review this Java Spring controller that fetches a user.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@GetMapping("/users/{id}")2public ResponseEntity<Map<String,Object>> getUser(@PathVariable String id) {3    User u = repo.findById(id).orElse(null);4    Map<String,Object> body = new HashMap<>();5    if (u == null) {6        body.put("error", "not found");7        return ResponseEntity.ok(body);8    }9    body.put("id", u.getId());10    body.put("name", u.getName());11    return ResponseEntity.ok(body);12}

Run or narrate your approach, then ask the coach.