Code reviewMediumcr-g362

Subject Leaky abstractionsLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java REST handler's catch-all error path.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@PostMapping("/search")2public ResponseEntity<?> search(@RequestBody Query q) {3    try {4        return ResponseEntity.ok(engine.run(q));5    } catch (Exception e) {6        return ResponseEntity.status(500)7            .body(Map.of("error", e.getMessage(),8                         "stack", Arrays.toString(e.getStackTrace())));9    }10}

Run or narrate your approach, then ask the coach.