Code reviewHardcr-g364

Subject Contract violationsLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this TypeScript serializer for a task API. The contract documents `assignee` as optional.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewtypescript

1function serializeTask(t: Task) {2  return {3    id: t.id,4    title: t.title,5    assignee: t.assigneeId ? lookupUser(t.assigneeId) : false,6    dueDate: t.dueDate ? t.dueDate.toISOString() : '',7  };8}

Run or narrate your approach, then ask the coach.