Code reviewHardcr-g367

Subject Backward compatibilityLevel Senior–Staff~25 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go change that adds a new field to a create-request struct for an existing v1 endpoint.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1type CreateInvoiceReq struct {2    CustomerID string   `json:"customer_id"`3    Amount     int64    `json:"amount"`4    Currency   string   `json:"currency"`5}6 7func createInvoice(w http.ResponseWriter, r *http.Request) {8    var req CreateInvoiceReq9    json.NewDecoder(r.Body).Decode(&req)10    if req.Currency == "" {11        http.Error(w, "currency is required", 400) // newly added check12    }13    inv := invoices.Create(req.CustomerID, req.Amount, req.Currency)14    writeJSON(w, 201, inv)15}

Run or narrate your approach, then ask the coach.