Code reviewMediumcr-g369

Subject OwnershipLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ resource handoff. `enqueue` takes ownership of the job; the caller logs the job id afterward.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1void enqueue(std::unique_ptr<Job> job);2 3void submit(std::unique_ptr<Job> job) {4    enqueue(std::move(job));5    // bookkeeping6    metrics.record("submit", job->id());   // (1)7    if (job->priority() > kHigh) {          // (2)8        scheduler.bump(job->id());9    }10}

Run or narrate your approach, then ask the coach.