Code reviewHardcr-g372

Subject LifetimesLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Rust parser that keeps a pointer to a slice of its own buffer to avoid re-scanning.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewrust

1struct Parser {2    buf: String,3    cursor: *const u8, // points into buf4}5 6impl Parser {7    fn new(s: String) -> Parser {8        let cursor = s.as_ptr();9        Parser { buf: s, cursor }10    }11    fn first(&self) -> u8 {12        unsafe { *self.cursor }13    }14}15 16let p = Parser::new("hello".into());17let p2 = p;          // move18let _ = p2.first();  // deref cursor

Run or narrate your approach, then ask the coach.