Code reviewHardcr-g373

Subject Memory safetyLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C dynamic buffer grow routine.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewc

1int buf_grow(Buffer *b, size_t need) {2    size_t newcap = b->cap ? b->cap * 2 : 16;3    while (newcap < need) newcap *= 2;4    b->data = realloc(b->data, newcap);   // grow in place5    if (!b->data) {6        free(b->data);7        return -1;8    }9    b->cap = newcap;10    return 0;11}

Run or narrate your approach, then ask the coach.