Code RoomReference to temporary returned

HardPrep Room Coding #2003

Reference to temporary returned

Code reviewCode quality & reviewSenior–Staff~22 min

Review this C++ accessor that returns a reference to the largest config value.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1const std::string& maxName(const std::map<int, std::string>& m) {

2 return m.empty() ? std::string{} : m.rbegin()->second;

3}

4

5// caller:

6const std::string& n = maxName(cfg);

7use(n);

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.