Code reviewHardcr-g375

Subject LifetimesLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ accessor that returns a reference to the largest config value.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1const std::string& maxName(const std::map<int, std::string>& m) {2    return m.empty() ? std::string{} : m.rbegin()->second;3}4 5// caller:6const std::string& n = maxName(cfg);7use(n);

Run or narrate your approach, then ask the coach.