Packet clone shares payload pointer

Code reviewCode quality & reviewMid–Senior~20 min

Review this C packet-cloning code used in a forwarding fast path.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min

Mark a line and say what kind of problem it is.0 findings

1typedef struct { uint8_t *payload; size_t len; } Packet;

3Packet clone_pkt(Packet src) {

4 Packet dst = src; // copy fields

5 dst.len = src.len;

6 return dst; // share payload pointer

9void handle(Packet p) {

10 Packet c = clone_pkt(p);

11 forward(&c);

12 free(c.payload);

13 free(p.payload);

14}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.