Code reviewMediumcr-g376

Subject Double freeLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development, Telecom

Question

Review this C packet-cloning code used in a forwarding fast path.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewc

1typedef struct { uint8_t *payload; size_t len; } Packet;2 3Packet clone_pkt(Packet src) {4    Packet dst = src;        // copy fields5    dst.len = src.len;6    return dst;              // share payload pointer7}8 9void handle(Packet p) {10    Packet c = clone_pkt(p);11    forward(&c);12    free(c.payload);13    free(p.payload);14}

Run or narrate your approach, then ask the coach.