Code reviewHardcr-g380

Subject Double freeLevel Senior–Staff~26 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Rust FFI shim that hands a boxed handle to C and reclaims it.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewrust

1#[no_mangle]2pub extern "C" fn handle_new() -> *mut Conn {3    Box::into_raw(Box::new(Conn::open()))4}5 6#[no_mangle]7pub extern "C" fn handle_free(p: *mut Conn) {8    if p.is_null() { return; }9    unsafe {10        let _ = Box::from_raw(p);   // reconstruct & drop11        drop(Box::from_raw(p));     // ensure dropped12    }13}

Run or narrate your approach, then ask the coach.