Code reviewMediumcr-g381

Subject Uninitialized memoryLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ class. The default constructor leaves a field unset on one path.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1class Sensor {2    int id_;3    double calib_;   // calibration factor4public:5    Sensor(int id) : id_(id) {6        if (id < 0) calib_ = 0.0;   // sentinel for invalid7        // valid ids: calib_ left for loadCalibration()8    }9    double read(double raw) const { return raw * calib_; }10};

Run or narrate your approach, then ask the coach.