Code RoomTask removal skips elements
MediumPrep Room Coding #2011

Task removal skips elements

Code reviewDatabases & SQLMid–Senior~18 min

Review this Rust code removing finished tasks from a vector by index.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1let mut tasks: Vec<Task> = load();
2let mut i = 0;
3while i < tasks.len() {
4 if tasks[i].done() {
5 tasks.swap_remove(i); // O(1) remove
6 }
7 i += 1;
8}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.