Code reviewMediumcr-g384

Subject Buffer overflowLevel Mid–Senior~18 minCommon in Algorithms & data structures interviewsIndustries Software development, Telecom

Question

Review this C function that builds a greeting string on the heap.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewc

1char *greet(const char *name) {2    size_t n = strlen(name);3    char *out = malloc(n);          // room for the name4    sprintf(out, "Hi, %s!", name);  // write greeting5    return out;6}

Run or narrate your approach, then ask the coach.