Code RoomToken span outlives vector

HardPrep Room Coding #2013

Token span outlives vector

Code reviewCode quality & reviewSenior–Staff~24 min

Review this C++ function returning a view over the parsed tokens.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 24 min

Mark a line and say what kind of problem it is.0 findings

1std::span<const Token> parse(std::string_view input) {

2 std::vector<Token> toks = tokenize(input);

3 return std::span<const Token>(toks); // hand back a view

4}

5

6auto view = parse(src);

7for (const Token& t : view) { process(t); }

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.