Code reviewHardcr-g385

Subject LifetimesLevel Senior–Staff~24 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ function returning a view over the parsed tokens.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1std::span<const Token> parse(std::string_view input) {2    std::vector<Token> toks = tokenize(input);3    return std::span<const Token>(toks);   // hand back a view4}5 6auto view = parse(src);7for (const Token& t : view) { process(t); }

Run or narrate your approach, then ask the coach.