Code reviewHardcr-g386

Subject Uninitialized memoryLevel Senior–Staff~28 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Rust code building a fixed config struct via MaybeUninit to skip a Default.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewrust

1use std::mem::MaybeUninit;2struct Config { host: String, port: u16, retries: u32 }3 4fn build(host: String, port: u16) -> Config {5    let mut c = MaybeUninit::<Config>::uninit();6    let p = c.as_mut_ptr();7    unsafe {8        (*p).host = host;            // (1)9        (*p).port = port;10        c.assume_init()              // retries never set11    }12}

Run or narrate your approach, then ask the coach.