Code RoomBuffer double-free with shared_ptr
HardPrep Room Coding #2016

Buffer double-free with shared_ptr

Code reviewCode quality & reviewSenior–Staff~24 min

Review this C++ cleanup code mixing shared_ptr with manual delete.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 24 min
Mark a line and say what kind of problem it is.0 findings
1std::shared_ptr<Buffer> buf = std::make_shared<Buffer>(4096);
2Buffer* raw = buf.get();
3// ... use ...
4delete raw; // free early to reclaim memory
5buf.reset(); // also drop the shared_ptr
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.