Code reviewHardcr-g388

Subject Double freeLevel Senior–Staff~24 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this C++ cleanup code mixing shared_ptr with manual delete.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewcpp

1std::shared_ptr<Buffer> buf = std::make_shared<Buffer>(4096);2Buffer* raw = buf.get();3// ... use ...4delete raw;        // free early to reclaim memory5buf.reset();       // also drop the shared_ptr

Run or narrate your approach, then ask the coach.