Undo shortcut ignores history changes

Code reviewCode quality & reviewSenior–Staff~22 min

Review this React TypeScript keyboard-shortcut hook.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1function useUndoShortcut(history: string[], onUndo: () => void) {

2 useEffect(() => {

3 const onKey = (e: KeyboardEvent) => {

4 if (e.key === 'z' && (e.metaKey || e.ctrlKey) && history.length > 0) {

5 onUndo();

6 }

7 };

8 window.addEventListener('keydown', onKey);

9 return () => window.removeEventListener('keydown', onKey);

10 }, []);

11}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.