Code reviewHardcr-g390

Subject Stale closureLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this React TypeScript keyboard-shortcut hook.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewtsx

1function useUndoShortcut(history: string[], onUndo: () => void) {2  useEffect(() => {3    const onKey = (e: KeyboardEvent) => {4      if (e.key === 'z' && (e.metaKey || e.ctrlKey) && history.length > 0) {5        onUndo();6      }7    };8    window.addEventListener('keydown', onKey);9    return () => window.removeEventListener('keydown', onKey);10  }, []);11}

Run or narrate your approach, then ask the coach.