Code RoomDashboard load dependency cycle
HardPrep Room Coding #2021

Dashboard load dependency cycle

Code reviewCode quality & reviewMid–Senior~20 min

Review this React TypeScript data loader.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1function Dashboard({ accountId }: { accountId: string }) {
2 const [data, setData] = useState<Row[]>([]);
3 
4 const load = async () => {
5 const res = await fetch(`/api/accounts/${accountId}/rows`);
6 setData(await res.json());
7 };
8 
9 useEffect(() => {
10 load();
11 }, [load]);
12 
13 return <Table rows={data} />;
14}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.