Code RoomSummary total ignores threshold changes
HardPrep Room Coding #2034

Summary total ignores threshold changes

Code reviewCode quality & reviewSenior–Staff~20 min

Review this React TypeScript filtered-summary component.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1function Summary({ rows, threshold }: { rows: Row[]; threshold: number }) {
2 const total = useMemo(() => {
3 return rows.filter((r) => r.value > threshold).reduce((s, r) => s + r.value, 0);
4 }, [rows]);
5 
6 return <strong>{total}</strong>;
7}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.