Code reviewHardcr-g412

Subject Atomicity violationsLevel Senior–Staff~28 minCommon in Concurrency interviewsIndustries Software development, Technology

Question

Review this Go high-water-mark tracker that records the largest latency seen, called from many request goroutines.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1type HighWater struct {2	max atomic.Int643}4 5func (h *HighWater) Observe(latencyNs int64) {6	if latencyNs > h.max.Load() {7		h.max.Store(latencyNs)8	}9}10 11func (h *HighWater) Max() int64 { return h.max.Load() }

Run or narrate your approach, then ask the coach.