Code reviewHardcr-g419

Subject Goroutine leaksLevel Senior–Staff~30 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go helper that races a primary and a fallback backend and returns whichever answers first.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func Query(ctx context.Context, primary, fallback Backend) (Result, error) {2	ch := make(chan Result)3	go func() { ch <- primary.Do(ctx) }()4	go func() { ch <- fallback.Do(ctx) }()5 6	select {7	case r := <-ch:8		return r, nil9	case <-ctx.Done():10		return Result{}, ctx.Err()11	}12}

Run or narrate your approach, then ask the coach.