Code RoomMerge channel not drained

HardPrep Room Coding #2053

Merge channel not drained

Code reviewCode quality & reviewSenior–Staff~28 min

Review this Go merge loop that drains two input channels and stops when both are exhausted.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 28 min

Mark a line and say what kind of problem it is.0 findings

1func merge(a, b <-chan int, out chan<- int) {

2 for {

3 select {

4 case v, ok := <-a:

5 if !ok { a = nil; continue }

6 out <- v

7 case v, ok := <-b:

8 if !ok { continue }

9 out <- v

10 }

11 }

12}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.