Invoice access lacks ownership check

Code reviewCode quality & reviewSenior–Staff~22 min

Review this Java Spring controller for fetching invoices.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1@GetMapping("/invoices")

2public List<Invoice> list(@RequestParam(required = false) Long orgId,

3 @AuthenticationPrincipal User me) {

4 if (orgId == null) {

5 orgId = me.getOrgId();

6 }

7 return invoiceRepo.findByOrgId(orgId);

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.