Code reviewHardcr-g433

Subject IdorLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java Spring controller for fetching invoices.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1@GetMapping("/invoices")2public List<Invoice> list(@RequestParam(required = false) Long orgId,3                          @AuthenticationPrincipal User me) {4    if (orgId == null) {5        orgId = me.getOrgId();6    }7    return invoiceRepo.findByOrgId(orgId);8}

Run or narrate your approach, then ask the coach.