Code reviewMediumcr-g434

Subject IdorLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python Flask endpoint that updates a shipping address.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1@app.route('/address/update', methods=['POST'])2@login_required3def update_address():4    body = request.get_json()5    addr = Address.query.get(body['address_id'])6    addr.line1 = body['line1']7    addr.city = body['city']8    db.session.commit()9    return {'ok': True}

Run or narrate your approach, then ask the coach.