Wallet decode overwrites all fields
Review this Go handler that updates a wallet via JSON.
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1type Wallet struct {
2 ID string `json:"id"`
3 Owner string `json:"owner"`
4 Balance float64 `json:"balance"`
5 Label string `json:"label"`
6}
7
8func UpdateWallet(w http.ResponseWriter, r *http.Request) {
9 id := mux.Vars(r)["id"]
10 wallet, _ := store.Get(id)
11 if err := json.NewDecoder(r.Body).Decode(&wallet); err != nil {
12 http.Error(w, "bad request", 400)
13 return
14 }
15 store.Save(wallet)
16}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.