Code reviewMediumcr-g439

Subject SsrfLevel Mid–Senior~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java image-proxy that blocks internal IPs.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1String fetch(String rawUrl) throws Exception {2    URL url = new URL(rawUrl);3    InetAddress addr = InetAddress.getByName(url.getHost());4    if (addr.isSiteLocalAddress() || addr.isLoopbackAddress()) {5        throw new SecurityException("blocked");6    }7    try (InputStream in = url.openStream()) {8        return new String(in.readAllBytes());9    }10}

Run or narrate your approach, then ask the coach.