Code reviewHardcr-g452

Subject Comparator violationsLevel Senior–Staff~20 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java comparator used to sort accounts by their (possibly large) balance in cents.

The values are `long` and can span the full ledger range.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1public int compare(Account a, Account b) {2    return (int) (a.balanceCents - b.balanceCents);3}

Run or narrate your approach, then ask the coach.