Code reviewHardcr-g453

Subject Comparator violationsLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java comparator that sorts trade fills by execution price (a double that can be NaN for voided fills).

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1List<Fill> fills = ...;2fills.sort((x, y) -> {3    if (x.price < y.price) return -1;4    if (x.price > y.price) return 1;5    return 0;6});

Run or narrate your approach, then ask the coach.