Trade price sort ignores NaN
Review this Java comparator that sorts trade fills by execution price (a double that can be NaN for voided fills).
What a strong answer looks like
Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.
0:00 of about 22 min
Mark a line and say what kind of problem it is.0 findings
1List<Fill> fills = ...;
2fills.sort((x, y) -> {
3 if (x.price < y.price) return -1;
4 if (x.price > y.price) return 1;
5 return 0;
6});
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.
Run or narrate your approach, then ask the coach.