Prep RoomSign inStart free
Code RoomBinary search with signed bounds
HardPrep Room Coding #2079

Binary search with signed bounds

Code reviewAlgorithms & data structuresSenior–Staff~18 min

Review this C++ binary search over an index range that can include negative coordinates (e.g. a signed axis).

It is called with `lo` as low as INT_MIN and `hi` near INT_MAX.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min
Mark a line and say what kind of problem it is.0 findings
1int search(const std::vector<int>& a, int lo, int hi, int target) {
2 while (lo <= hi) {
3 int mid = lo + (hi - lo) / 2;
4 if (a[mid] == target) return mid;
5 else if (a[mid] < target) lo = mid + 1;
6 else hi = mid - 1;
7 }
8 return -1;
9}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.