Code Room
Code reviewMediumcr-g456
Subject Short circuit evaluationLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go validation that records each failed check for a metrics counter, then decides whether the request is valid.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewgo
func validate(r Req) bool {    return recordIfBad(checkAuth(r)) ||        recordIfBad(checkRate(r)) ||        recordIfBad(checkSchema(r))} // recordIfBad returns true when the check FAILED, and increments a per-check failure counter.func recordIfBad(failed bool) bool {    if failed { failureCounter.Inc() }    return failed}
Run or narrate your approach, then ask the coach.