Code reviewHardcr-g457

Subject Null handlingLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that returns a discount percent, defaulting to 0 when no override is present.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1Integer override = overrides.get(userId); // may be null2int percent = (condition) ? override : 0;3return percent;

Run or narrate your approach, then ask the coach.