Code Room
Code reviewHardcr-g461
Subject Edge casesLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java helper that returns a non-negative bucket from a possibly-negative hash, used as an array index.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewjava
int bucket(int hash, int n) {    return Math.abs(hash) % n;}
Run or narrate your approach, then ask the coach.