Code reviewMediumcr-g464

Subject Null handlingLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java code that returns a cached user or loads (and caches) one on a miss.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1User u = cache.get(id);                 // returns null on miss2return Optional.ofNullable(u)3               .orElse(loadAndCache(id)); // loadAndCache hits the DB

Run or narrate your approach, then ask the coach.