Code reviewHardcr-g471

Subject Off by oneLevel Senior–Staff~18 minCommon in Databases & SQL interviewsIndustries Software development

Question

Review this Go function that returns the p-th percentile latency from a sorted slice (e.g. p=95 for p95).

`sorted` is ascending and non-empty; `p` is in [0, 100].

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func percentile(sorted []float64, p int) float64 {2    idx := (p * len(sorted)) / 1003    return sorted[idx]4}

Run or narrate your approach, then ask the coach.