Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g475
Subject Inefficient data structureLevel Mid–Senior~18 minCommon in Algorithms & data structures interviewsIndustries Software development

Question

Review this Python BFS-style worker that drains a task list.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
def drain(tasks):    processed = []    while tasks:        task = tasks.pop(0)   # take from the front        processed.append(task)        for child in expand(task):            tasks.append(child)    return processed
Run or narrate your approach, then ask the coach.