Code RoomFull table scan filters

HardPrep Room Coding #2102

Full table scan filters

Code reviewCode quality & reviewMid–Senior~22 min

Review this Python (SQLAlchemy) lookup for a user’s recent active orders.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1def recent_active(session, user_id):

2 orders = session.query(Order).all() # load the whole table

3 result = []

4 for o in orders:

5 if o.user_id == user_id and o.status == "active":

6 if o.created_at >= last_30_days():

7 result.append(o)

8 return result

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.