Code reviewMediumcr-g478

Subject Regex recompileLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python validator called on every request.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1import re2 3def is_valid_sku(sku):4    pattern = re.compile(r"^[A-Z]{3}-\d{4}-[A-Z0-9]{2}$")5    return bool(pattern.match(sku))

Run or narrate your approach, then ask the coach.