Code reviewMediumcr-g479

Subject Regex recompileLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java log filter run over every line of a large file.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1List<String> errors(List<String> lines) {2    List<String> out = new ArrayList<>();3    for (String line : lines) {4        if (line.matches("^\\d{4}-\\d{2}-\\d{2}.*\\bERROR\\b.*")) {5            out.add(line);6        }7    }8    return out;9}

Run or narrate your approach, then ask the coach.