Code reviewMediumcr-g480

Subject Missing cacheLevel Senior–Staff~20 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go permission check called on every request.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func CanAccess(userID, resource string) bool {2    roles := fetchRolesFromDB(userID)        // network round trip3    policy := compilePolicy(loadPolicyFile()) // reads + parses a static YAML file from disk4    return policy.Allows(roles, resource)5}

Run or narrate your approach, then ask the coach.