Code RoomPermission check on every request
MediumPrep Room Coding #2105

Permission check on every request

Code reviewCode quality & reviewSenior–Staff~20 min

Review this Go permission check called on every request.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1func CanAccess(userID, resource string) bool {
2 roles := fetchRolesFromDB(userID) // network round trip
3 policy := compilePolicy(loadPolicyFile()) // reads + parses a static YAML file from disk
4 return policy.Allows(roles, resource)
5}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.