Code reviewHardcr-g483

Subject Boxing overheadLevel Senior–Staff~22 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go metrics aggregator on a hot path.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func record(metrics map[string]interface{}, name string, v float64) {2    metrics[name] = v   // float64 boxed into interface{}3}4 5func total(metrics map[string]interface{}) float64 {6    var sum float647    for _, raw := range metrics {8        sum += raw.(float64)   // type assertion per entry9    }10    return sum11}

Run or narrate your approach, then ask the coach.