Synchronous I/O blocks request handler

Code reviewCode quality & reviewMid–Senior~22 min

Review this Node.js Express handler.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 22 min

Mark a line and say what kind of problem it is.0 findings

1const fs = require("fs");

2const dns = require("dns");

4app.get("/report", (req, res) => {

5 const cfg = JSON.parse(fs.readFileSync("./report.json", "utf8"));

6 const addr = dns.lookupSync ? dns.lookupSync(cfg.host) : require("dns").lookup;

7 const data = fs.readFileSync(cfg.path, "utf8");

8 res.send(render(cfg, data));

9});

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.