Code Room
Code reviewMediumcr-g486
Subject Inefficient data structureLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Go dedup check run for every incoming event.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Talk through your review
Code to reviewgo
var seen []string func isDuplicate(id string) bool {    for _, s := range seen {   // linear scan of everything seen so far        if s == id {            return true        }    }    seen = append(seen, id)    return false}
Run or narrate your approach, then ask the coach.