Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g487
Subject Unnecessary allocationLevel Mid–Senior~14 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python filter that drops blocked users.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
def visible(comments, blocked_ids):    out = []    for c in comments:        if c.author_id not in list(blocked_ids):   # blocked_ids is already a set            out.append(c)    return out
Run or narrate your approach, then ask the coach.