Code RoomUnnecessary list() conversion
MediumPrep Room Coding #2112

Unnecessary list() conversion

Code reviewCode quality & reviewMid–Senior~14 min

Review this Python filter that drops blocked users.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 14 min
Mark a line and say what kind of problem it is.0 findings
1def visible(comments, blocked_ids):
2 out = []
3 for c in comments:
4 if c.author_id not in list(blocked_ids): # blocked_ids is already a set
5 out.append(c)
6 return out
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.