Maximum recomputed every iteration

Code reviewCode quality & reviewMid–Senior~18 min

Review this Java method that normalizes scores.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1double[] normalize(List<Double> scores) {

2 double[] out = new double[scores.size()];

3 for (int i = 0; i < scores.size(); i++) {

4 out[i] = scores.get(i) / maxOf(scores); // recompute max every iteration

5 }

6 return out;

9double maxOf(List<Double> xs) {

10 double m = Double.NEGATIVE_INFINITY;

11 for (double x : xs) m = Math.max(m, x);

12 return m;

13}

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.