Code reviewMediumcr-g488

Subject Repeated workLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Java method that normalizes scores.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjava

1double[] normalize(List<Double> scores) {2    double[] out = new double[scores.size()];3    for (int i = 0; i < scores.size(); i++) {4        out[i] = scores.get(i) / maxOf(scores);   // recompute max every iteration5    }6    return out;7}8 9double maxOf(List<Double> xs) {10    double m = Double.NEGATIVE_INFINITY;11    for (double x : xs) m = Math.max(m, x);12    return m;13}

Run or narrate your approach, then ask the coach.