Prep Room
Sign inCreate account
Code Room
Code reviewMediumcr-g489
Subject Quadratic loopsLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this Python function that returns unique records preserving order.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts
Talk through your review
Code to reviewpython
def unique(records):    result = []    for r in records:        is_dup = False        for seen in result:          # scan everything kept so far            if seen.key == r.key:                is_dup = True                break        if not is_dup:            result.append(r)    return result
Run or narrate your approach, then ask the coach.