Code reviewMediumcr-g490

Subject Repeated workLevel Mid–Senior~18 minCommon in Code quality & review interviewsIndustries Software development

Question

Review this JavaScript function that emails a batch of users.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewjavascript

1function renderAll(users, templateSource) {2  return users.map((u) => {3    const compiled = Handlebars.compile(templateSource); // compile per user4    return compiled({ name: u.name, plan: u.plan });5  });6}

Run or narrate your approach, then ask the coach.