Keys snapshot on every merge

Code reviewCode quality & reviewMid–Senior~18 min

Review this Python merge of per-shard counters.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 18 min

Mark a line and say what kind of problem it is.0 findings

1def merge(shards):

2 totals = {}

3 for shard in shards:

4 for k, v in shard.items():

5 keys = list(totals.keys()) # snapshot keys each time

6 if k in keys:

7 totals[k] = totals[k] + v

8 else:

9 totals[k] = v

10 return totals

Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.