Code reviewMediumcr-g493

Subject Retry logicLevel Mid–Senior~16 minCommon in Code quality & review interviewsIndustries Software development, Technology

Question

Review this Go retry wrapper that retries a POST with a JSON body on transient failures.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewgo

1func postWithRetry(url string, body io.Reader) (*http.Response, error) {2    var lastErr error3    for attempt := 0; attempt < 3; attempt++ {4        req, _ := http.NewRequest("POST", url, body)5        resp, err := http.DefaultClient.Do(req)6        if err == nil && resp.StatusCode < 500 {7            return resp, nil8        }9        lastErr = err10        time.Sleep(time.Duration(attempt) * 200 * time.Millisecond)11    }12    return nil, lastErr13}

Run or narrate your approach, then ask the coach.