Code RoomCharge creation with idempotency key
HardPrep Room Coding #2119

Charge creation with idempotency key

Code reviewNetworking & APIsSenior–Staff~20 min

Review this Java payment endpoint. Clients send an `Idempotency-Key` header to make charge creation safe to retry.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix, specific and kind.

0:00 of about 20 min
Mark a line and say what kind of problem it is.0 findings
1public ChargeResult createCharge(String idempotencyKey, ChargeRequest req) {
2 Optional<ChargeResult> existing = idemRepo.findByKey(idempotencyKey);
3 if (existing.isPresent()) {
4 return existing.get();
5 }
6 ChargeResult result = processor.charge(req);
7 idemRepo.save(idempotencyKey, result);
8 return result;
9}
Which questions mattered is sealed until you submit. Telling you now would just be handing over the edge cases.