Code reviewMediumcr-g495

Subject Error handlingLevel Mid–Senior~16 minCommon in Distributed systems · Code quality & review interviewsIndustries Software development

Question

Review this Python data-loader. The caller needs to retry on a transient `ConnectionError` but give up on a `SchemaError`.

What a strong answer looks like

Separate real bugs from style. Rank issues by severity, point at the root cause rather than the symptom, and suggest a concrete fix — specific and kind.

Learn the concepts

Talk through your review

Code to reviewpython

1def load_partition(part):2    try:3        return store.read(part)4    except Exception as e:5        raise RuntimeError(f"failed to load {part}: {e}")6 7def run(parts):8    for p in parts:9        try:10            load_partition(p)11        except ConnectionError:12            retry_later(p)13        except SchemaError:14            quarantine(p)

Run or narrate your approach, then ask the coach.